fix: treat a function call's None args as empty in sync AFC, matching async - #3011
Open
Yasser-Ameur wants to merge 2 commits into
Open
Yasser-Ameur wants to merge 2 commits into
Yasser-Ameur wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronous automatic function calling helper get_function_response_parts skips any FunctionCall whose args field is None, which happens for any tool declared with no parameters. Chat.send_message therefore hands the bare function call back to the caller instead of running the tool.
The async twin, get_function_response_parts_async, already treats None as an empty dict before invoking the tool. That fallback was added in commit e3be9af (Add Agent Platform MCP support to async generate_content) but the sync function was never updated to match, so AsyncChat.send_message and Chat.send_message diverge for zero argument tools.
This change mirrors the async fallback in the sync function, two lines, no new abstraction, so both paths behave the same way.
Added three offline tests to the existing test_get_function_response_parts.py covering None args on both the sync and async paths and empty dict args, so the regression is caught either way in the future.
I can share a small repro script alongside the tests if useful for review.